feat(browser): Flush offline queue on flush and browser online event
#14764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
flush and browser online eventflush and browser online event
joshkel
approved these changes
Dec 17, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dev-packages/browser-integration-tests/suites/transport/offline/flush/test.ts
Fixed
Show fixed
Hide fixed
dev-packages/browser-integration-tests/suites/transport/offline/flush/test.ts
Fixed
Show fixed
Hide fixed
AbhiPrasad
approved these changes
Dec 18, 2024
Member
|
Let's make sure we backport this to v8! We can get it released for that. |
Contributor
|
@AbhiPrasad Is the plan still to backport this offline-flush feature to Sentry v8? I can accept either way, I'm just hoping to know for planning purposes. Thank you. |
Collaborator
Author
Sorry I must have missed this! I will backport to v8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
flushso that sending is retriedflushwhen theonlineevent is fired